aidenlx / alx-folder-note

Add description, summary, and more info to folders with folder notes.
MIT License
246 stars 13 forks source link

Improve handling of loading folder-note-core API #67

Closed meatbagger closed 2 years ago

meatbagger commented 2 years ago

The entire plugin is failing to initialize on a MacOS device and iOS device after having worked flawlessly for many weeks.

Plugin version: 0.16.0 MacOS Obsidian version: 0.14.2 (I use Insider builds) iOS Obsidian version: 1.1.1 (48)

It appears the error gets logged somewhere but I cannot figure out where, I apologize. Happy to give further information. I don't use GitHub at all - my bad if I am doing something wrong.

Thank you for your very hard work on this great plugin.

hsiktas commented 2 years ago

I see this error in the dev tools console:

Uncaught (in promise) Error: Failed to initialize alx-folder-note: Click here for more details at sr.get CoreApi [as CoreApi] (eval at (app.js:1:1444405), :46:20204) at Fi (eval at (app.js:1:1444405), :46:1524) at sr.eval (eval at (app.js:1:1444405), :47:83) at Generator.next () at o (eval at (app.js:1:1444405), :6:972)

aidenlx commented 2 years ago

can you check the setting tab of aidenlx's folder note to see if folder note core is installed and enabled?

hsiktas commented 2 years ago

Does this look right to you?

https://user-images.githubusercontent.com/4571159/160394621-4251f3d6-974e-43b7-a74a-95d98737945b.mp4

AmbushXXVI commented 2 years ago

This is happening with me on PC as well, though the vault is stored on a google drive and also opened on MacOS as well. Core is installed.

aidenlx commented 2 years ago

I’m having trouble reproducing the issue… could you send the debug info (should be a command called show debug info) and upload the .obsidian config folder in zip file?

AmbushXXVI commented 2 years ago

SYSTEM INFO: Obsidian version: v0.13.33 Installer version: v0.12.19 Operating system: Windows 10 Pro 10.0.19044 Login status: not logged in Insider build toggle: off Live preview: on Legacy editor: on Base theme: dark Community theme: none Snippets enabled: 0 Safe mode: off Plugins installed: 14 Plugins enabled: 13 1: Table Extended 2: Dataview 3: Templater 4: Admonition 5: Find unlinked files and unresolved links 6: Buttons 7: Banners 8: TTRPG Statblocks 9: AidenLx's Folder Note 10: Folder Note Core 11: Automatically reveal active file 12: Find and replace in selection 13: Icon Shortcodes

RECOMMENDATIONS: Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the help vault or disable community plugins. Ambush.obsidian.zip

hsiktas commented 2 years ago

Here is my debug info:

SYSTEM INFO: Obsidian version: v0.14.2 Installer version: v0.13.31 Operating system: Darwin Kernel Version 21.4.0: Mon Feb 21 20:34:37 PST 2022; root:xnu-8020.101.4~2/RELEASE_X86_64 21.4.0 Login status: logged in Catalyst license: insider Insider build toggle: on Live preview: on Legacy editor: off Base theme: light Community theme: Minimal Snippets enabled: 0 Safe mode: off Plugins installed: 51 Plugins enabled: 51 1: System Dark Mode 2: Editor Syntax Highlight 3: Dictionary 4: Calendar 5: Advanced Tables 6: Readwise Official 7: Excalidraw 8: File Explorer Note Count 9: Folder Note Core 10: Footlinks 11: Graph Analysis 12: Highlightr 13: Hotkey Helper 14: Icon Shortcodes 15: Kanban 16: Key Promoter 17: Linter 18: Mind Map 19: Natural Language Dates 20: Note Refactor 21: Obsidian42 - BRAT 22: Paste URL into selection 23: Simple Embeds 24: Style Settings 25: Tasks 26: Todoist Plugin 27: Underline 28: Zoottelkeeper Plugin 29: Checklist 30: cMenu 31: Flashcards 32: Hide Sidebars When Narrow 33: LanguageTool Integration 34: Link Favicons 35: Quick Latex for Obsidian 36: Pandoc Plugin 37: Ozan's Image in Editor Plugin 38: Outliner 39: Obsidian Git 40: Minimal Theme Settings 41: Dataview 42: Convert url to preview (iframe) 43: Excel to Markdown Table 44: Frontmatter Tag Suggest 45: Save as Gist 46: AidenLx's Folder Note - folderv component 47: Hover Editor 48: Settings Search 49: Version History Diff (Sync, File Recovery & Git) 50: Admonition 51: AidenLx's Folder Note

I noticed that disabling and enabling the plugin works without producing that error, and now it seems like the plugin load order changed with this plugin at last place. So, I can't reproduce the issue anymore. :)

aidenlx commented 2 years ago

@AmbushXXVI @meatbagger could you try disable and reenable aidenlx’s folder note to see if it still occurs?

AmbushXXVI commented 2 years ago

seems to have cleared for me

meatbagger commented 2 years ago

Hello - disabling and re-enabling the plugin on MacOS cleared the issue for both MacOS and iOS. The most basic of IT fixes eluded me, apparently. Thank you all.

aidenlx commented 2 years ago

v0.16.1 should handle the case where folder-note-core loads after this plugin properly