aidenlx / obsidian-icon-shortcodes

Obsidian Plugin: Insert emoji and custom icons with shortcodes
MIT License
146 stars 11 forks source link

Better ordering of Emoji suggestions #47

Closed GollyTicker closed 2 years ago

GollyTicker commented 2 years ago

First of all, I and very thankful for this plugin :star: . I enjoy using emojis in my notes as the small images make some content more easily communicated.

However, during usage of the plugin, I noticed, that the order of the suggesting emojis when starting a shoartcode : is sub-optimal.

Consider these shortcodes: star, heart, x and right When using the first three, I expect, that after typing it out, the top-most suggestion is the most specific one corresponding to it. e.g. for star I expect the star :star: suggestion to be top-most. However, we see a different list: image

The same problem also appears with the other shortcodes.

image

image

This is less helpful, as sometimes we need to scroll down a lot to see the right emoji.

For the prefix right, we get these suggestions: image

However, I think it's better, when shorter completions such as arrow_right, fist_right and copyright are higher prioritised than the other ones. Generally, if the suffix needed to complete the shortcode is short, then the emoji should be higher on the list.

And for the case of x, if the emoji is short alltogether and has a relatively large matching with the prefix shortcode, then it should be also higher on the list.

Most other existing emoji shortcode suggestion lists seem to return, what I would intuitively expect. For instance, when writing an issue comment, the github emojis suggest this:

Screenshot from 2022-05-08 17-06-08

Screenshot from 2022-05-08 17-07-37

Screenshot from 2022-05-08 17-06-52

Could we have the shortcodes prioritised differently?

What do you think? :star:

If there is need, I could provide some help.

GollyTicker commented 2 years ago

Sorry, I made this issue in the wrong repository.

aidenlx commented 2 years ago

😂It's ok. Maybe you can try this plugin instead, it support emoji as well and provide better fuzzy search result:

image
GollyTicker commented 2 years ago

@aidenlx Honestly... You are right :smile:

I tried your plugin and it does do this correctly. And furthermore, you've more features available.

I think, that more people could be using your plugin - but many people don't discover your plugin, since it does not have "emoji" in it's title. It gets lower prioritsed, when the following list is recommended: image

Given this list of suggestions, people would usually directly take the first or second plugin.

But as emoji's are a core feature of your's, why don't you add it to the title? :wink:

aidenlx commented 2 years ago

well basically because the plugin is design on top of emoji shortcode with additional support for custom icons, and I couldn't find a better name that includes emoji😂, and btw it's sorted by installed count so renaming it won't change the order here.