Add API Dialect - Githubissues

aidenwallis / kysely-d1

D1 dialect for Kysely

MIT License

206 stars 12 forks source link

Add API Dialect #12

Open tom-sherman opened 1 year ago

tom-sherman commented 1 year ago

[x] I have verified my changes didn't break the example project.

Description

Closes #7

This PR adds a new dialect that allows you to Kysely and D1 outside of cloudflare workers eg. in Deno and Node.

Note I'd recommend not squashing these changes as I've structured the commits to preserve the history/renaming of index.ts -> d1-dialect.ts

aidenwallis commented 1 year ago

@tom-sherman I'm thinking we should maybe consider closing this PR branch until there's official API support for this from Cloudflare.

We can keep an issue open to track this, if that works for you! 👍

aidenwallis commented 1 year ago

Did this API ever get documented?

adam-the commented 1 year ago

I think that it could be worthwhile adding this, even if the APIs aren't documented yet. In their Discord server, Cloudflare has committed to eventually documenting/stabilising the API and even endorse projects made around it such as this one: https://github.com/isaac-mcfadyen/d1-console

Accepting this pull request will allow for easier access for those who wish to experiment with it and enable anyone to submit maintenance changes for the feature in this project going forward.