Reference Cloudflare workers type by import

aidenwallis / kysely-d1

D1 dialect for Kysely

MIT License

206 stars 12 forks source link

Reference Cloudflare workers type by import #18

Closed zhuhaow closed 1 year ago

zhuhaow commented 1 year ago

This avoids conflicts between "DOM" and @cloudflare/workers-types. See https://github.com/cloudflare/workers-types/issues/164

[x] I have verified my changes didn't break the example project.

Description

aidenwallis commented 1 year ago

This PR fails with the prettier check, can you run npm run format on your branch and push those changes? Thanks!

aidenwallis commented 1 year ago

Given that this is a major bump with a sub-dependency, and cloudflare don't seem to be offering super stable types for D1 right now, I'm going to version this as a major release in case we nuke packages that depend on us. 👍

zhuhaow commented 1 year ago

I think the lock file in the example is still a little problematic. Checking

aidenwallis commented 1 year ago

Worked for me, I can fix this in the release branch. 👍

zhuhaow commented 1 year ago

It should work since it's referencing the parent folder from the example. Just not sure why.

aidenwallis commented 1 year ago

It'll be sorted in the release branch. 👍

zhuhaow commented 1 year ago

Awesome, thanks.