aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
15.89k stars 558 forks source link

Million Lint Ignoring custom webpack config #1003

Open LPSebi opened 3 months ago

LPSebi commented 3 months ago

What version of million are you using?

3.0.6

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Chrome, Firefox

Describe the Bug

Million Lint v0.0.73

image When updating the webpack config in next.config.mjs it will not get applied when using million lint and will therefore show this error: image

What's the expected result?

Apply the webpack config changes correctly

Link to Minimal Reproducible Example

-

Participation

github-actions[bot] commented 3 months ago

Thanks for opening this issue! A maintainer will review it soon.

tobySolutions commented 3 months ago

Thank you for this, the team is actively working on this.

Archimagus commented 3 months ago

Just to add to this. It also doesn't seem to support loaders correctly.

  webpack: (config) => {
    config.module.rules.push({
      test: /\.(frag|vert|glsl)$/,
      type: 'asset/source',
    });
    return config;
  },
./src/materials/shaders/CustomDiffuse.frag
Module parse failed: Unexpected token (1:0)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> #ifdef USE_MAP
|   vec4 col1 = texture2D( map, vMapUv );
|   if(diffuseColor.a < 0.5) 

It works correctly without million.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

Sliov commented 2 months ago

Same issue here

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

Archimagus commented 2 months ago

No word on support for this?

tobySolutions commented 2 months ago

No word on support for this?

Hey there @Archimagus, this is being worked on by the team and will be available in the next release. I'll confirm with the team to be sure as well.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

ImLunaHey commented 1 month ago

bad bot