aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
15.89k stars 558 forks source link

Million Lint Onboarding: Support Cursor as well as VSCode #1004

Closed DannyAziz closed 2 months ago

DannyAziz commented 3 months ago

Describe the feature

Got stuck in a loop trying to login to million but currently the deeplink only goes over to VSCode

I got over this by using a devtools content override and changing the window.open call to the following: window.open("cursor://million.million-lint/auth?token=".concat(n) + "&name=" + (null === (e = i.user) || void 0 === e ? void 0 : e.fullName), "_blank")

A button on the UI would be awesome

Additional information

github-actions[bot] commented 3 months ago

Thanks for opening this issue! A maintainer will review it soon.

DannyAziz commented 3 months ago

I guess this is more than just the onboarding flow, even when using the Open feature inside the web app it tries to open the file inside vscode

Screenshot 2024-03-20 at 12 17 52

tobySolutions commented 3 months ago

Thank you for opening this @DannyAziz, I will inform the team of this.

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

alexdanilowicz commented 1 month ago

+1 on this

nucks commented 1 month ago

+1

A-kamal commented 1 month ago

+1 🙏

kennethcassel commented 1 month ago

came here checking for cursor support +1!

Kosmoon commented 1 month ago

+1