search

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
15.89k stars 558 forks source link

Death by letter X #1012

Closed Alexander-Fransson closed 3 months ago

Alexander-Fransson commented 3 months ago

What version of million are you using?

2.6.0

Are you using an SSR adapter? If so, which one?

no

What package manager are you using?

yarn

What operating system are you using?

Linux mint

What browser are you using?

firefox

Describe the Bug

Creates components that kills the app upon the usage of the letter x in p & h tags.

This code :

x

Gives this message in the terminal: now renders ~14% faster.

Similar issues appear when using p tags.

What's the expected result?

The expected result is that it just renders the normal component and that the app does not die.

Link to Minimal Reproducible Example

https://DidNotRealyUnderstandWhatToLinkHere.com

Participation

  • [ ] I am willing to submit a pull request for this issue.
github-actions[bot] commented 3 months ago

Thanks for opening this issue! A maintainer will review it soon.

tobySolutions commented 3 months ago

Hello there @Alexander-Fransson , can you please provide a Stackblitz / CodeSandbox reproduction of the issue you're getting so I can help out?

Alexander-Fransson commented 3 months ago

Hi, sorry for the inconvenience,

I believe I made a workaround yesterday and now I’m seemingly unable to recreate the error.

Ill remove the issue for now, but I’ve noticed it a couple of times so maybe Ill repost it once Im able to recreate it.

If there are other issues where the terminal states that some random string component runs faster and the screen becomes black it is probably related.

Best wishes, Alexander Fransson

On Thu, 4 Apr 2024 at 23:20, Tobiloba Adedeji @.***> wrote:

Hello there @Alexander-Fransson https://github.com/Alexander-Fransson , can you please provide a Stackblitz / CodeSandbox reproduction of the issue you're getting so I can help out?

— Reply to this email directly, view it on GitHub https://github.com/aidenybai/million/issues/1012#issuecomment-2038245972, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQXVRYLZOYYHXXUMLPQ7PDDY3W7ZFAVCNFSM6AAAAABFVYHOJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGI2DKOJXGI . You are receiving this because you were mentioned.Message ID: @.***>