search

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.26k stars 574 forks source link

bug: 2nd CTA button "millionjs in 100 seconds" is slightly too low contrast #431

Closed CBID2 closed 1 year ago

CBID2 commented 1 year ago

Describe the bug A clear and concise description of what the bug is. The color of the second button clashes with the color of its text, which according to WAVE's accessibility checker (see information in screenshot below) makes it difficult for users with low vision to read.

Possible Solution Wave recommends the following: "Increase the contrast between the foreground (text) color and the background color. Large text (larger than 18 point or 14 point bold) does not require as much contrast as smaller text." Perhaps we can find a color that's similar to the current colors and accessible.

Expected behavior A clear and concise description of what you expected to happen. N/A Screenshots If applicable, add screenshots to help explain your problem. low contrast

Device (please complete the following information):

Additional context Add any other context about the problem here.

aidenybai commented 1 year ago

Will be fixed in a bundled PR soon.