aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.09k stars 561 forks source link

Millionjs compatibility with lodable when using webpack 4 #576

Closed jainChetan81 closed 9 months ago

jainChetan81 commented 10 months ago

What version of million are you using?

2.5.13

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

yarn

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

We are using lodable, with webpack 4 config at my office, the stack is custom built SSR without and framework, for reference this link here is the repo we are using to build or web app. The problem I am facing is with lodable on cold start, it has trouble understanding lodable config and I couldn't find a way to overrride this without breaking anything else and I couldn't understand the error.

error images

Screenshot 2023-09-13 at 3 36 46 PM Screenshot 2023-09-13 at 3 36 59 PM

What's the expected result?

Million should be able to work with lodable

Link to Minimal Reproducible Example

https://github.com/wellyshen/react-cool-starter

Participation

aidenybai commented 10 months ago

@jainChetan81 can you try on latest?

tobySolutions commented 10 months ago

Hey @jainChetan81! Any updates on this?

jainChetan81 commented 10 months ago

same issue, using this with million@2.6.0 now

Drex72 commented 9 months ago

Hey @jainChetan81 ,retry again with version 2.6.4 if it persists, let us know

jainChetan81 commented 9 months ago

Sure, will update here...