aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.19k stars 567 forks source link

fix(website): youtube embed component mobile sizing #854

Closed MatthewStanciu closed 8 months ago

MatthewStanciu commented 8 months ago

Please describe the changes this PR makes and why it should be merged:

The YouTube embed on the "Back in Block" blog post looks broken on mobile:

Screenshot 2023-12-27 at 4 46 55 PM

This is actually already fixed on the /ai page. This PR brings that fix over to this blog post.

Screenshot 2023-12-27 at 4 45 49 PM

It also uses the aspect-ratio CSS property, which is now supported in all major browsers.

Status

Semantic versioning classification:

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 9:51pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 9:51pm
CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

aidenybai commented 8 months ago

very epic matthew, thank you