breaking: remove slot - Githubissues

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.

https://million.dev

MIT License

16.19k stars 567 forks source link

breaking: remove slot #858

Closed Aslemammad closed 6 months ago

Aslemammad commented 8 months ago

Resolves #567

Forking its-fine and making the APIs ref compatible
removing the marker element and passing the parent/container ref instead

Status

[ ] Code changes have been tested against prettier, or there are no code changes
[ ] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase
- [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
- [ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

CLAassistant commented 8 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

:white_check_mark: rishi-raj-jain
:white_check_mark: tobySolutions
:white_check_mark: oliverloops
:white_check_mark: aidenybai
:white_check_mark: haideralipunjabi
:white_check_mark: Drex72
:white_check_mark: MatthewStanciu
:white_check_mark: Timonwa
:white_check_mark: Aslemammad
:x: johnjyang
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
million-kitchen-sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 6:07am
sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 6:07am

Aslemammad commented 8 months ago

Ahh, it's getting messy because of the v3 rebase!

tobySolutions commented 8 months ago

Ahh, it's getting messy because of the v3 rebase!

Is it cool, now? Can I help?

Aslemammad commented 8 months ago

Is it cool, now? Can I help?

Not yet, but for now let's focus on the implementation, I'll let you know for sure. Thank you so much.

tobySolutions commented 8 months ago

Is it cool, now? Can I help?

Not yet, but for now let's focus on the implementation, I'll let you know for sure. Thank you so much.

My pleasure!

github-actions[bot] commented 7 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.