search

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.19k stars 567 forks source link

Gsap and Million.js #860

Closed VeroniDeev closed 7 months ago

VeroniDeev commented 8 months ago

What version of million are you using?

2.5.1

Are you using an SSR adapter? If so, which one?

Nextjs

What package manager are you using?

pnpm

What operating system are you using?

Linux

What browser are you using?

Brave (chromium)

Describe the Bug

When I have million.js installed on my project I see that gsap doesn't work but when I remove million.js it does. I see a lot of slots in devtool that ruin my gsap animation.

image

What's the expected result?

I was expecting my gsap animation to work, but it didn't.

Link to Minimal Reproducible Example

https://stackblitz.com/~/github.com/VeroniDeev/million-bug

Participation

github-actions[bot] commented 8 months ago

Thanks for opening this issue! A maintainer will review it soon.

tobySolutions commented 8 months ago

Any updates on this @VeroniDeev?

VeroniDeev commented 8 months ago

In fact the problem is still there but when I delete million the problem is solved, when I open devtool, it shows me lots of slots with a width of 0, which prevents me from making animations. And i forgot its million 2.6.4 not 2.5.1

tobySolutions commented 8 months ago

In fact the problem is still there but when I delete million the problem is solved, when I open devtool, it shows me lots of slots with a width of 0, which prevents me from making animations. And i forgot its million 2.6.4 not 2.5.1

So, are you saying it works now? Also, what's your setup like?

VeroniDeev commented 8 months ago

In fact the problem is still there but when I delete million the problem is solved, when I open devtool, it shows me lots of slots with a width of 0, which prevents me from making animations. And i forgot its million 2.6.4 not 2.5.1

So, are you saying it works now? Also, what's your setup like?

No, it still doesn't work when I use million on my animation components with gsap and I can see why. When I open my chrome devtool, I see a lot of slots with a width of size 0 and it's because of the slot size that my problem persists.

The solution is to disable the "auto" setting and disable million on my gsap components.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.