aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.19k stars 567 forks source link

Fix Rules of Blocks link in FAQ #862

Closed abduelhamit closed 8 months ago

abduelhamit commented 8 months ago

Please describe the changes this PR makes and why it should be merged:

The link for the Rules of Blocks in the FAQ needs to be fixed. This PR attempts that.

Status

Semantic versioning classification:

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 1:21pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2024 1:21pm
CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

tobySolutions commented 8 months ago

Awesome! Thanks @abduelhamit, reviewing it now

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7410072716


Totals Coverage Status
Change from base Build 7394469090: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls
tobySolutions commented 8 months ago

For some reason @abduelhamit, the FAQ link is not in the header for this your PR and the FAQ page looks very bad, see what I mean below and check out million.dev:

Screenshot 2024-01-05 at 11 22 30 Screenshot 2024-01-05 at 11 22 19