search

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.19k stars 567 forks source link

📝 Docs: Website has React key complaints #869

Closed JoshuaKGoldberg closed 8 months ago

JoshuaKGoldberg commented 8 months ago

When I run the website locally and visit the homepage, I get the dreaded https://reactjs.org/link/warning-keys complaint:

Warning: Each child in a list should have a unique "key" prop.

Check the top-level render call using <...>. See https://reactjs.org/link/warning-keys for more information.

...in two components:

https://github.com/aidenybai/million/blob/65ef9aff64597f56feb4401d13519844badc533c/website/components/home/hero.tsx#L155-L156

https://github.com/aidenybai/million/blob/65ef9aff64597f56feb4401d13519844badc533c/website/components/home/showcase.tsx#L72-L77

There's something amusing about a performance library triggering the React key complaint that's commonly associated with performance (albeit on a relatively static docs site).

Is there a reason React ESLint plugins to catch this aren't enabled on the website?

github-actions[bot] commented 8 months ago

Thanks for opening this issue! A maintainer will review it soon.

tobySolutions commented 8 months ago

Thank you so much for this @JoshuaKGoldberg!