aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
16.19k stars 567 forks source link

Bug: Automatic Mode Made False Claims Of Perf Improvements In This Case #870

Closed tobySolutions closed 8 months ago

tobySolutions commented 8 months ago

What version of million are you using?

2.6.4

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

A user complained about not getting any differences in lighthouse perf scores, even when automatic mode in the terminal told them that certain components in their application had performance improvements:

"I inherited React app done with create-react-app. I added craco and setup million on it.

The code base is really awful. So, quick win? Hypothesis: Add Million and get a 10% boost?

I'm the lead for FE here, so my job is to select our next tech stack. I'd prefer to stay on React (Next.js) and add Million to boost it to Svelte speed numbers. Thus, I was using our current site as a guinea pig to prove we should use React + Million.

I could share more, but not publicly." - User

Before:

before-img

After:

after-img

Even when Million at build time said this:

after-img

What's the expected result?

The expected results is to know that the results Million provides in the terminal tallies to a huge extent as to results testing softwares provides and stuff

Link to Minimal Reproducible Example

https://media.discordapp.net/attachments/938129049539186761/1192906374355619840/image.png?ex=65aac7a2&is=659852a2&hm=68cf439de606a17e6a60287856fa3ac94c369708f0aef077e7d553712f07ecf1&=&format=webp&quality=lossless&width=1062&height=150

Participation

github-actions[bot] commented 8 months ago

Thanks for opening this issue! A maintainer will review it soon.

tobySolutions commented 8 months ago

Can we take a look at this @aidenybai, it's kind of important.