aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
15.94k stars 559 forks source link

Documentation(i18n): Translate the docs to Spanish #923

Closed glitch-txs closed 5 months ago

glitch-txs commented 5 months ago

Please describe the changes this PR makes and why it should be merged:

Manual Mode

Internals

Status

Semantic versioning classification:

closes https://github.com/aidenybai/million/issues/907

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 9:47pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 9:47pm
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

tobySolutions commented 5 months ago

Awesome work @glitch-txs!! Thanks.

glitch-txs commented 5 months ago

thanks! @tobySolutions! I think it's done, could you review?

For some reason /es-ES/docs/manual-mode/for gives me 404 as well on local

tobySolutions commented 5 months ago

Awesome!!! Thanks @glitch-txs 🙌🙌🙌. I'll review it in a bit.

tobySolutions commented 5 months ago

thanks! @tobySolutions! I think it's done, could you review?

For some reason /es-ES/docs/manual-mode/for gives me 404 as well on local

It does not work in prod as well? I'll check it out and let you know.

That's certainly weird.

glitch-txs commented 5 months ago

haven't tried on prod, will give it one last read to the whole thing just in case

glitch-txs commented 5 months ago

there are some warning that are written in English because they are components, may we could make this components to receive a prop with the text so it can be trasnlated on the dif pages image

glitch-txs commented 5 months ago

also this part seems off from main docs, it's talking about the For component but the example shows a block? image

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 7702882312


Totals Coverage Status
Change from base Build 7699303649: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls
tobySolutions commented 5 months ago

there are some warning that are written in English because they are components, may we could make this components to receive a prop with the text so it can be trasnlated on the dif pages image

Hmm, do you want to work on that?

tobySolutions commented 5 months ago

also this part seems off from main docs, it's talking about the For component but the example shows a block? image

Oh, the as is right there; it's the thing with the as: div

glitch-txs commented 5 months ago

Hmm, do you want to work on that?

sure, since it might be breaking change for other languages we can do it in another PR if that's ok

tobySolutions commented 5 months ago

Hmm, do you want to work on that?

sure, since it might be breaking change for other languages we can do it in another PR if that's ok

Yeah, much later on. Can you pull latest changes? I just committed something directly to main.

tobySolutions commented 5 months ago

Reviewing it now @glitch-txs

glitch-txs commented 5 months ago

Thanks! Let me know if there any changes left 🫡

tobySolutions commented 5 months ago

Thanks! Let me know if there any changes left 🫡

Ok, so I fixed the For page issue. I'm making a push now

tobySolutions commented 5 months ago

Great work @glitch-txs!! Thanks 🙌