Closed glitch-txs closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
million-kitchen-sink | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 29, 2024 9:47pm |
sink | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jan 29, 2024 9:47pm |
Awesome work @glitch-txs!! Thanks.
thanks! @tobySolutions! I think it's done, could you review?
For some reason /es-ES/docs/manual-mode/for
gives me 404 as well on local
Awesome!!! Thanks @glitch-txs 🙌🙌🙌. I'll review it in a bit.
thanks! @tobySolutions! I think it's done, could you review?
For some reason
/es-ES/docs/manual-mode/for
gives me 404 as well on local
It does not work in prod as well? I'll check it out and let you know.
That's certainly weird.
haven't tried on prod, will give it one last read to the whole thing just in case
there are some warning that are written in English because they are components, may we could make this components to receive a prop with the text so it can be trasnlated on the dif pages
also this part seems off from main docs, it's talking about the For component but the example shows a block?
Totals | |
---|---|
Change from base Build 7699303649: | 0.0% |
Covered Lines: | 1257 |
Relevant Lines: | 5082 |
there are some warning that are written in English because they are components, may we could make this components to receive a prop with the text so it can be trasnlated on the dif pages
Hmm, do you want to work on that?
also this part seems off from main docs, it's talking about the For component but the example shows a block?
Oh, the as
is right there; it's the thing with the as: div
Hmm, do you want to work on that?
sure, since it might be breaking change for other languages we can do it in another PR if that's ok
Hmm, do you want to work on that?
sure, since it might be breaking change for other languages we can do it in another PR if that's ok
Yeah, much later on. Can you pull latest changes? I just committed something directly to main.
Reviewing it now @glitch-txs
Thanks! Let me know if there any changes left 🫡
Thanks! Let me know if there any changes left 🫡
Ok, so I fixed the For
page issue. I'm making a push now
Great work @glitch-txs!! Thanks 🙌
Please describe the changes this PR makes and why it should be merged:
Manual Mode
Internals
Status
Semantic versioning classification:
closes https://github.com/aidenybai/million/issues/907