is it memoized? - Githubissues

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.

https://million.dev

MIT License

15.94k stars 559 forks source link

is it memoized? #941

Closed mstanton closed 4 months ago

mstanton commented 5 months ago

just a suggestion! I'll update when and if I get more info. This project is great. :-)

Please describe the changes this PR makes and why it should be merged: Memoize and update some conditional logic in compiler/index.ts

Status Experimental 🥼

[ ] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[x] This PR changes the codebase
- [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
- [x] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
million-kitchen-sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 3, 2024 9:09am
sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 3, 2024 9:09am

CLAassistant commented 5 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions[bot] commented 5 months ago

Pull Request Test Coverage Report for Build 7765896407

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.

-10 of 10 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 3.617%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/compiler/index.ts	0	10	0.0%
<!--	Total:	0	10	0.0%	-->

Totals
Change from base Build 7765582614:	0.007%
Covered Lines:	884
Relevant Lines:	27078

💛 - Coveralls

github-actions[bot] commented 4 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.