aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.

https://million.dev

MIT License

16.26k stars 574 forks source link

fix(compiler): properly checking `app` dir inside `src` dir #959

Closed 0x221A closed 6 months ago

0x221A commented 7 months ago

958

Please describe the changes this PR makes and why it should be merged:

Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[x] This PR changes the codebase
- [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
- [x] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
million-kitchen-sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 9, 2024 10:40pm
sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 9, 2024 10:40pm

CLAassistant commented 7 months ago

All committers have signed the CLA.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7850418247

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

-2 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 3.617%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/compiler/index.ts	0	2	0.0%
<!--	Total:	0	2	0.0%	-->

Totals
Change from base Build 7841623579:	-0.001%
Covered Lines:	884
Relevant Lines:	27073

💛 - Coveralls

github-actions[bot] commented 7 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

0x221A commented 7 months ago

@Aslemammad stale?

github-actions[bot] commented 6 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.