Add playsInline for videos with autoPlay attribute

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.

https://million.dev

MIT License

15.89k stars 558 forks source link

Add playsInline for videos with autoPlay attribute #979

Closed jahirfiquitiva closed 2 months ago

jahirfiquitiva commented 4 months ago

Please describe the changes this PR makes and why it should be merged:

This will prevent videos from playing in full-screen unexpectedly on iOS.

Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase
- [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
- [ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
[x] This PR only includes non-code changes, like changes to documentation, README, etc.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
million-kitchen-sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 1, 2024 7:37pm
sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 1, 2024 7:37pm

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 8116332381

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 3.524%

Totals
Change from base Build 8101237008:	0.0%
Covered Lines:	884
Relevant Lines:	27799

💛 - Coveralls

jahirfiquitiva commented 4 months ago

This is a video showing the unexpected behavior ... all I did was switch to the "Million Lint" tab

https://github.com/aidenybai/million/assets/10360816/8e35bdc2-1364-437a-9c0c-f95a34124826

github-actions[bot] commented 3 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

github-actions[bot] commented 2 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

jahirfiquitiva commented 2 months ago

@aidenybai @tobySolutions any chance you could look into this, please?

github-actions[bot] commented 2 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.