aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.
https://million.dev
MIT License
15.89k stars 558 forks source link

Million.js Lint Not Working #994

Closed Bader975 closed 1 month ago

Bader975 commented 3 months ago

What version of million are you using?

V3.0.6

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

npm

What operating system are you using?

windows

What browser are you using?

Chrome

Describe the Bug

Million.js Lint not working Screenshot 2024-03-17 072717

What's the expected result?

it's should give hits to speed up my React app

Link to Minimal Reproducible Example

none , no error

Participation

github-actions[bot] commented 3 months ago

Thanks for opening this issue! A maintainer will review it soon.

lucarampi commented 3 months ago

Same problem.

My nextjs config file: (tryed with and without rsc, both auto mode) image

yarn run dev cli messages image

AndreiTS commented 3 months ago

Same problem here: image

Info:

Alcas1 commented 3 months ago

Same problem here:

oskarscholander commented 3 months ago

Same! 👋

BaileyNepe commented 3 months ago

I get this issue as well when running in a bun workspace, however when I run on a different app using npm and not in a workspace, the linting works fine.

cold-world commented 3 months ago

same

Windows 11 npm: 10.5.0 vite: 5.1.6 @million/lint: 0.0.73

N0SAFE commented 3 months ago

same

Windows 11 npm 10.2.5 next 14.1.3 @million/lint 0.0.73

EliKnoph commented 3 months ago

Same here!

Windows 11 npm 10.2.4 vite 5.0.10 @million/lint: 0.0.73

cold-world commented 3 months ago

and also it makes errors with react key prop all over the app

emedeirox commented 3 months ago

Same

Windows 11 pnpm 8.15.5 vite 5.1.4 @million/lint: 0.0.73

tobySolutions commented 3 months ago

Hmm, thank you all for coming here to report this. I have reported this team and it's currently being worked on. Appreciate it:

giovanniincammicia commented 3 months ago

Hi, mine is the same, but I have a vscode notification that says: "million lint is successfully installed...waiting for connection" and never disappears. I tried logging into: https://lint.million.dev, but it immediately says: "session expired, log in again".

To test the linter, I've used a client component with a useEffect that runs setState(v => v + 1) indefinitely, producing infinite re-renders. Is it a good test that million lint should be able to recognize?

tobySolutions commented 3 months ago

Hi, mine is the same, but I have a vscode notification that says: "million lint is successfully installed...waiting for connection" and never disappears. I tried logging into: https://lint.million.dev, but it immediately says: "session expired, log in again".

To test the linter, I've used a client component with a useEffect that runs setState(v => v + 1) indefinitely, producing infinite re-renders. Is it a good test that million lint should be able to recognize?

We're currently working on this actually. A fix will be sent in the next patch of the Million lint release

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

brendon1555 commented 2 months ago

Has there been any progress on this? Particularly with it not working in a workspace?

sudexp commented 2 months ago

The same issue for me (react/vite, yarn, mac os) fixed with:

  1. yarn add -D million@latest
  2. yarn add -D @million/lint
  3. vite.config.ts: ... import million from 'million/compiler'; import MillionLint from '@million/lint';

export default defineConfig({ plugins: [ ... react(), million.vite({ auto: true }), MillionLint.vite(), ], ... });

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

Alcas1 commented 2 months ago

Not stale

J4v4Scr1pt commented 2 months ago

Same as all the others.

Windows 10 pnpm 8.8.8 next 14.2.3 @million/lint 0.0.73

cold-world commented 2 months ago

The same issue for me (react/vite, yarn, mac os) fixed with:

  1. yarn add -D million@latest
  2. yarn add -D @million/lint
  3. vite.config.ts: ... import million from 'million/compiler'; import MillionLint from '@million/lint';

export default defineConfig({ plugins: [ ... react(), million.vite({ auto: true }), MillionLint.vite(), ], ... });

this works with million lint but it gives a lot of errors in project like missing key props in react, react-hook-form and tanstack-query not working properly.

Bader975 commented 2 months ago

@cold-world how install Million.js lint on Next,js 14 ?

tobySolutions commented 2 months ago

@cold-world how install Million.js lint on Next,js 14 ?

Hey there, just follow this: https://million.dev/docs/introduction

jacksmethurst commented 1 month ago

Hitting the same issue, any updates?

oskarscholander commented 1 month ago

Is there any new updates?

aidenybai commented 1 month ago

Please continue the thread here: #1029