fix: #996 Handle property alias

aidenybai / million

Optimize React performance and make your React 70% faster in minutes, not months.

https://million.dev

MIT License

15.89k stars 558 forks source link

fix: #996 Handle property alias #997

Closed AlexanderArvidsson closed 1 month ago

AlexanderArvidsson commented 3 months ago

Please describe the changes this PR makes and why it should be merged: Fixes #996. As this resolves unintended behavior, but technically does change the output of the generated HTML, it is up to you if you want to consider this as a breaking change or not.

Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[x] This PR changes the codebase
- [x] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
- [x] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
million-kitchen-sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2024 11:43am
sink	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2024 11:43am

CLAassistant commented 3 months ago

All committers have signed the CLA.

AlexanderArvidsson commented 3 months ago

Compare the difference in the following two Kitchen Sink demos and go to SVG:

Before PR: https://million-kitchen-sink-git-fork-jahirfiquitiva-patch-1-millionjs.vercel.app

After pr: https://million-kitchen-sink-git-fork-alexanderarvidss-9f9029-millionjs.vercel.app

This change makes SVGs render correctly, even in your demo :)

AlexanderArvidsson commented 3 months ago

I've now fixed the failed test due to linting! Seems my linter wasn't working the first time around; sorry about that!

github-actions[bot] commented 3 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

AlexanderArvidsson commented 3 months ago

Not stale, still waiting for review from @lxsmnsyc, @NisargIO.

github-actions[bot] commented 2 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

AlexanderArvidsson commented 2 months ago

Not stale

github-actions[bot] commented 1 month ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.