aidhound / hotxlfp

A Python Excel Formula Parser similar to the javascript handsontable formulaparser
MIT License
27 stars 12 forks source link

ATAN2 - y_param not used #9

Closed geraldvienna closed 3 years ago

geraldvienna commented 3 years ago

In this line https://github.com/aidhound/hotxlfp/blob/master/hotxlfp/formulas/mathtrig.py#L145 there should be y_num = utils.parse_number(y_num) but atm it is y_num = utils.parse_number(x_num)

leonelcamara commented 3 years ago

This led me to find some errors in the testing of mathtrig. I'll fix it!

leonelcamara commented 3 years ago

@geraldvienna I released a new version with the fixes thanks a lot for your bug reporting.