search

aido / app-seed-tool

A Ledger application that provides some useful seed management utilities
Apache License 2.0
42 stars 2 forks source link

Improve code readability and verify safety of cryptographic functions #1

Closed mkoese closed 1 year ago

aido commented 1 year ago

@mkoese Nice.

The files you updated were copied from https://github.com/BlockchainCommons/bc-shamir. Maybe create a similar PR for the originals too?

I have already raised an issue on some of the CodeQL warnings: https://github.com/BlockchainCommons/bc-shamir/issues/42

Also, your PR fails the lint test so if you fix that one small thing then I'll merge.

mkoese commented 1 year ago

@aido I was going through your code. I just want to review your work. Adding comments simplifies it. I greatly appreciate your work!