aidotse / PASEOS

PASEOS - PAseos Simulates the Environment for Operating multiple Spacecraft
GNU General Public License v3.0
38 stars 9 forks source link

Student #205

Open GabrieleMeoni opened 10 months ago

GabrieleMeoni commented 10 months ago

Description

Summary of changes

Resolved Issues

How Has This Been Tested?

Refer to the specific tests included in the PR. Issue #207 shall be taken into account in a separate PR.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 10 months ago

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py33197%49
   paseos.py1481292%67–68, 145–146, 213, 228, 246, 255, 273, 304, 312–315
paseos/activities
   activity_manager.py43393%46, 74, 157
   activity_processor.py58198%121
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py2233385%24–30, 33, 223–225, 252–254, 299–308, 339, 345, 493, 572–573, 588, 624, 671, 702, 714–718, 725–726, 733–734
   base_actor.py1351887%85, 107, 123, 188, 228–230, 251, 260, 277, 298, 304–307, 313, 328, 383
   ground_station_actor.py15380%47–53
   spacecraft_actor.py1081487%65–71, 79–85, 93–99, 198, 253, 262–265
   spacecraft_body_model.py52492%54, 89, 142, 157
paseos/attitude
   attitude_model.py89298%159, 168
   disturbance_torques_utils.py694929%46–222
paseos/central_body
   central_body.py73692%70, 179–180, 188–189, 258
   is_in_line_of_sight.py581771%106–123, 167, 174–187
   mesh_between_points.py35294%71, 79
   sphere_between_points.py26869%35–38, 48–51, 63–64
paseos/communication
   find_next_window.py201525%29–60
   get_communication_window.py231822%35–66
paseos/power
   charge_model.py16194%49
   discharge_model.py7271%22, 34
paseos/tests
   activity_test.py57395%90, 93–94
   attitude_test.py683351%93–129, 137–166
   eclipse_test.py10190%20
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py62494%143–146
   mesh_test.py119397%118, 139, 147
   thermal_model_test.py30197%61
   visualization_test.py18194%28
paseos/utils
   check_cfg.py611870%31, 40, 46, 60–62, 67, 70–72, 75–77, 80–82, 98, 103
   operations_monitor.py71396%127–130
   reference_frame_transfer.py72889%108, 132, 240–242, 245–247
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%29–32
   space_animation.py2152389%108–109, 124, 153–154, 188, 212–219, 225, 335, 358–360, 365, 374–375, 379, 415, 421–422, 453, 467–478
TOTAL265532888% 

Tests Skipped Failures Errors Time
38 0 :zzz: 0 :x: 0 :fire: 1m 6s :stopwatch:
GabrieleMeoni commented 10 months ago

Issue #207 shall be taken into account in a separate PR.

gomezzz commented 9 months ago

@rasmusmarak this is the work @GabrieleMeoni was mentioning in our call. Maybe, a good first step for you could be to create a small example notebook branching out of this to try out if you can compute the point on Earth's surface that a satelliteActor is pointing at? Ideally any problems and questions that arise during that can also be used in this PR as feedback. (Maybe @GabrieleMeoni could start by just adding a few sentences to the readme on how to use this to enable this?)

ghost commented 9 months ago

@rasmusmarak this is the work @GabrieleMeoni was mentioning in our call. Maybe, a good first step for you could be to create a small example notebook branching out of this to try out if you can compute the point on Earth's surface that a satelliteActor is pointing at? Ideally any problems and questions that arise during that can also be used in this PR as feedback. (Maybe @GabrieleMeoni could start by just adding a few sentences to the readme on how to use this to enable this?)

Sounds like a good start, I'll make sure to have a look at some initial notebook example! :-)