search

aidudezzz / deepbots

A wrapper framework for Reinforcement Learning in the Webots robot simulator using Python 3.
https://deepbots.readthedocs.io/
GNU General Public License v3.0
243 stars 50 forks source link

Fixed the deprecation warning #109

Closed KelvinYang0320 closed 2 years ago

KelvinYang0320 commented 2 years ago

When using KeyboardPrinter in keyboard_printer, users will get the following warning. warning This might confuse users.

tsampazk commented 2 years ago

Thanks @KelvinYang0320 , could you fix the same issue in the supervisor_emitter_receiver.py so we get two birds in one stone? :D

KelvinYang0320 commented 2 years ago

@tsampazk I think that is the same issue. This warning is raised by get_timestep() and we still use it in KeyboardPrinter. https://github.com/aidudezzz/deepbots/blob/bd8a0d6601bbe316d5ac0fffbbb17abc888bf57d/deepbots/supervisor/controllers/supervisor_emitter_receiver.py#L94-L99 After using .timesetp in our deepbots package, cartpolt/carpole_discrete/CartPoleWorldEmitterReceiver can work without this warning. DId you get this warning in other deepworld examples?

tsampazk commented 2 years ago

You are absolutely right, sorry about that, i have encountered lots of issues and opened and ran lots of different things, so i was confused :laughing: I checked the whole deepbots directory for usages of get_timestep and found only the one in keyboard printer so we are good to go!

tsampazk commented 2 years ago

Disregard the failing test, it seems that it cannot find the python version to install or something along those lines.