aidudezzz / deepbots

A wrapper framework for Reinforcement Learning in the Webots robot simulator using Python 3.
https://deepbots.readthedocs.io/
GNU General Public License v3.0
243 stars 50 forks source link

Modify Docker #123

Closed KelvinYang0320 closed 1 year ago

KelvinYang0320 commented 1 year ago
KelvinYang0320 commented 1 year ago

DockerHub: https://hub.docker.com/u/aidudezzz

KelvinYang0320 commented 1 year ago

Thanks, just a minor comment. Maybe we could also remove all the $ from the bash commands so users can straight up use the copy button provided by github UI and then paste directly into their terminal?

@tsampazk That's a good point! I have updated this PR. 😄

KelvinYang0320 commented 1 year ago

@tsampazk Since we added a requirement.txt, we need to install via https://github.com/KelvinYang0320/deepbots/blob/7821c55e4881610897f13dcdd5b85bb905687097/docker/Dockerfile#L27-L29. I update README accordingly and push 0.1.3.dev4 to Docker Hub.

tsampazk commented 1 year ago

Alright @KelvinYang0320 thank you! Should we wait for the discussed release before further updating and merging this?

KelvinYang0320 commented 1 year ago

Should we wait for the discussed release before further updating and merging this?

Yes, I agree. 👌