search

aidudezzz / deepworlds

Examples and use cases using the deepbots framework (https://github.com/aidudezzz/deepbots) with the Webots robot simulator.
GNU General Public License v3.0
50 stars 23 forks source link

Finalize the khr-3hv environment. #49

Closed NikosKokkinis closed 1 year ago

NikosKokkinis commented 3 years ago

Finalize the khr-3hv environment for the GSoC 2021.

KelvinYang0320 commented 3 years ago

Hello, @NickKok. I am reviewing the khr-3hv part of your work. Did you get _AttributeError: module 'aioredis' has no attribute 'create_redispool' when USE_Ray = True? Check out this link. I downgraded aioredis to v1.3.1 to run and keep reviewing your work for now.

KelvinYang0320 commented 3 years ago

@NickKok Thank you for contributing many examples to deepworlds! Also, the code quality is great!

This PR includes

I only do the code review on khr-3hv as the description of this PR. Could you separate these examples into different branches and open PR for each? And write the title & description for each PR according to changed files. In this way, I think we can discuss or record these examples more clearly. Thanks! :smile:

NikosKokkinis commented 3 years ago

Hello @KelvinYang0320.

No I didn't get any error on : AttributeError: module 'aioredis' has no attribute 'create_redis_pool' when USE_Ray = True?

When you downgraded aioredis to v1.3.1, does it work with Ray?

KelvinYang0320 commented 3 years ago

When you downgraded aioredis to v1.3.1, does it work with Ray?

@NickKok Yes, everything goes fine when downgrading aioredis to v1.3.1, as suggested on this website. I follow your readme to pip install all packages. Could you start from pip install these packages again to see if you can reproduce this problem? Thank you

tsampazk commented 2 years ago

Hey @NickKok! We would like to take over this PR and finalize it if you don't mind, unless you have some free time to do so yourself. You could resolve whatever comments exist right now, merge it and we can take over perfecting it later.

This needs to be closed in combination with other fixes we've been doing for #58, so as to bring all existing examples up to speed with the latest Webots release.

NikosKokkinis commented 2 years ago

Hello @tsampazk. It won't be possible to work on it till the end of August. After that It might be possibl during weekends. If you would like to continue the work feel free. I could help you from September.

tsampazk commented 2 years ago

Alright @NickKok, thanks for the quick response, we will probably continue working on this and finalize it soon then. There's always more work to be done so if you feel like it you can contribute in the future 😃

tsampazk commented 1 year ago

Hey @KelvinYang0320, could we close this PR as i think all the goals were met by #76 ?

KelvinYang0320 commented 1 year ago

@tsampazk There are three examples, cartpole, khr-3hv, and nao, in this PR.

I think we can close this PR and open an issue for it. What do you think?

tsampazk commented 1 year ago

Oh yes i didn't notice the other two, sorry. The cartpole stable-baselines stuff are already present in the dev branch :confused:, so we need a new PR that adds the nao example? Bottom line i think it's better to close it and open an issue as you suggested!

KelvinYang0320 commented 1 year ago

@tsampazk I have a nao branch on my fork. Do you want me to open a draft PR or push it to a new branch on aidudezzz/deepworlds directly? As for cartpole, I think he also modified our existing cartpole stable-baselines. Unfortunately, I cannot remember the detail. :confused:

tsampazk commented 1 year ago

@tsampazk I have a nao branch on my fork. Do you want me to open a draft PR or push it to a new branch on aidudezzz/deepworlds directly?

I don't mind, whatever you feel is easier for you!

As for cartpole, I think he also modified our existing cartpole stable-baselines. Unfortunately, I cannot remember the detail. confused

It's ok, by taking a quick look at the sb cartpole we need to refactor and update that example anyway!