search

aidudezzz / deepworlds

Examples and use cases using the deepbots framework (https://github.com/aidudezzz/deepbots) with the Webots robot simulator.
GNU General Public License v3.0
50 stars 23 forks source link

Refactored Deepbots: DeepbotsEnv & Robot Class #80

Closed KelvinYang0320 closed 1 year ago

KelvinYang0320 commented 1 year ago

This PR is corresponding to

KelvinYang0320 commented 1 year ago

@tsampazk This PR works fine with the latest KHR-3HV example since it doesn't use an emitter/receiver. We can rebase and merge it when you think it is ready. :smile:

KelvinYang0320 commented 1 year ago

@tsampazk I think I didn't rename all function names and variable names to snake_case last time. I add a few commits to this PR. Could you check if all examples in deepworlds work fine again? Thank you!

tsampazk commented 1 year ago

We can change stuff regarding test pypi like this one https://github.com/KelvinYang0320/deepworlds/blob/45b4a6b1ad3a2ece68b4dbfb0ab65be6caa7caed/README.md?plain=1#L25 .

I don't think there are other similar stuff that need changing in the deepworlds repo, right?

tsampazk commented 1 year ago

Hey @KelvinYang0320 , should we go ahead and merge this for the examples to work properly for the 1.0 release? Is there anything left to do?

KelvinYang0320 commented 1 year ago

@tsampazk Could you check if all examples work fine again for me? I just rebased and squashed the commits. If all examples work without error, I think we are ready to go.

tsampazk commented 1 year ago

Sure thing @KelvinYang0320 , thank you