aidygus / LinVAM

Linux Voice Activated Macro
GNU General Public License v3.0
58 stars 6 forks source link

Fixes & implementation of playing audio files. See changes.md for det… #3

Closed smirgol closed 3 years ago

smirgol commented 4 years ago

First, thanks a lot for creating a project! I was looking for something to replace VoiceAttack which I've used on windows and this tool really helped me out.

On windows I was using HCS voicepacks and I was really missing the audio feedback from these, so I've implemented playing audio files into your tool.

While having quite some coding experience, this is actually the first time I do write something in python, so some things might not be super optimal or best practice.

I've encountered some issues with your tool, like not being able to change profiles, I fixed that along the way. For a full list of changes, issues and thoughts, please see the changes.md file.

One thing to note about the xdotool integration: I have quite some issues running your script with sudo, so I've looked into an alternative for sending key commands. xdotool comes in handy here, although it really has its issues, where the target window for unknown reasons does not receive the commands. Sometimes it works, sometimes not, it's still puzzling me.

Please have a look if you like the changes and would like to merge it with your branch. :-)

So here's the commit log, taken from changes.md:

aidygus commented 3 years ago

Spot on! Thanks for the bugfixes and improvements.