search

aiekick / ImGuiFileDialog

Full featured file Dialog for Dear ImGui
MIT License
1.25k stars 202 forks source link

UTF8 fixes for 'std::filesystem' version of `IFileSystem` #171

Closed m9710797 closed 7 months ago

m9710797 commented 8 months ago

As discussed in: https://github.com/aiekick/ImGuiFileDialog/issues/170

Big caveat: I tried to be careful in creating this PR, but I was NOT able to test or even compile this code on Windows!

Please read the commit message for lots more details.

aiekick commented 8 months ago

thanks will check and try to test that. your fix seems very elegant :)

m9710797 commented 8 months ago

Hi. No problem if you didn't have time yet. But since there hasn't been any activity on this PR for a week, I wanted to give this a ping.

aiekick commented 8 months ago

Hi, i not see any improvement since i guess i have no font with the extra symbols. btw, yes its not my priority at this moment. You know IGFD is maintained on my spare time, and since im not paid for work on it, its not my priority regarding paid projects. btw, its not an issue here, since, the IFilesystem purpose, is to let the user use its own fs. so you can apply your modification yourself. Btw in your case its strange to propose a cross platfom software so with users on winwdows who have a bug but no devs on windows to fix it. you know you can install a vm with win10 on linux on it (even a trial version of windows)

m9710797 commented 8 months ago

Hi. I was now able to test this PR on a windows machine. And I can confirm it fixes the bug.