search

aiellc2 / flow-tools

Automatically exported from code.google.com/p/flow-tools
Other
0 stars 0 forks source link

error: format not a string literal and no format arguments [-Werror=format-security] #28

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. add -Werror=format-security to CFLAGS
2. build
3. watch it break:

DEBUG: fterr.c: In function 'fterr_info':
DEBUG: fterr.c:115:5: error: format not a string literal and no format 
arguments [-Werror=format-security]
DEBUG:      syslog(LOG_INFO, buf);
DEBUG:      ^
DEBUG: fterr.c: In function 'fterr_err':
DEBUG: fterr.c:137:5: error: format not a string literal and no format 
arguments [-Werror=format-security]
DEBUG:      syslog(LOG_INFO, buf2);
DEBUG:      ^
DEBUG: fterr.c: In function 'fterr_errx':
DEBUG: fterr.c:162:5: error: format not a string literal and no format 
arguments [-Werror=format-security]
DEBUG:      syslog(LOG_INFO, buf);
DEBUG:      ^
DEBUG: fterr.c: In function 'fterr_warnx':
DEBUG: fterr.c:186:5: error: format not a string literal and no format 
arguments [-Werror=format-security]
DEBUG:      syslog(LOG_INFO, buf);
DEBUG:      ^
DEBUG: fterr.c: In function 'fterr_warn':
DEBUG: fterr.c:208:5: error: format not a string literal and no format 
arguments [-Werror=format-security]
DEBUG:      syslog(LOG_INFO, buf2);
DEBUG:      ^
DEBUG: cc1: some warnings being treated as errors

What is the expected output? What do you see instead?

Should just build.

What version of the product are you using? On what operating system?

0.68.5 on Fedora/rawhide

Please provide any additional information below.

Fedora is using -Werror=format-security in CFLAGS and flow-tools fails to 
build. Attached patch fixes it.

Original issue reported on code.google.com by marcin...@gmail.com on 24 Jun 2014 at 6:30

Attachments: