Closed gfrances closed 3 years ago
Looks good Guillem :+1:
On Wed, 12 May 2021, 00:07 Guillem Francès, @.***> wrote:
See #99 https://github.com/aig-upf/tarski/pull/99 for the rationale to this PR
You can view, comment on, or merge this pull request online at:
https://github.com/aig-upf/tarski/pull/103 Commit Summary
- Import psutil conditionally; install it only in Linux platforms
File Changes
- M setup.py https://github.com/aig-upf/tarski/pull/103/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7 (5)
- M src/tarski/utils/resources.py https://github.com/aig-upf/tarski/pull/103/files#diff-22198bbba4b1fba50275e6c7a69d7e42bec82a5a83a8ee0d6a0ab7d17a53f5d6 (25)
- A tests/test_utils.py https://github.com/aig-upf/tarski/pull/103/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33 (13)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMQKJONQX2KH3YEALAWQTTNE23TANCNFSM44VTMB2Q .
It fail some checks?
Yes, but they seem related to some code in a previous commit by @miquelramirez (easy to see the first failing commit here). @miquelramirez , do you think this is fixable? Or maybe I could move the NDL-related commits to a diff branch (they seem pretty self-contained, but I've only given a quick glance)?
Cheers for the heads up, it's a trivial issue, will fix soon.
On Wed, 12 May 2021, 16:25 Guillem Francès, @.***> wrote:
Yes, but they seem related to some code in a previous commit by @miquelramirez https://github.com/miquelramirez (easy to see the first failing commit here https://github.com/aig-upf/tarski/commits/devel). @miquelramirez https://github.com/miquelramirez , do you think this is fixable? Or maybe I could move the NDL-related commits to a diff branch (they seem pretty self-contained, but I've only given a quick glance)?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/103#issuecomment-839494623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMQKOISWZWLR2T2YSLSOLTNINNJANCNFSM44VTMB2Q .
Should be fixed with commit b4be590ba4dfa5b05d8b11b5a2685fbeef4c5383
See #99 for the rationale to this PR