search

aig-upf / tarski

Tarski - An AI Planning Modeling Framework
Apache License 2.0
59 stars 19 forks source link

Import psutil conditionally; install it only in Linux platforms #103

Closed gfrances closed 3 years ago

gfrances commented 3 years ago

See #99 for the rationale to this PR

miquelramirez commented 3 years ago

Looks good Guillem :+1:

On Wed, 12 May 2021, 00:07 Guillem Francès, @.***> wrote:

See #99 https://github.com/aig-upf/tarski/pull/99 for the rationale to this PR

You can view, comment on, or merge this pull request online at:

https://github.com/aig-upf/tarski/pull/103 Commit Summary

  • Import psutil conditionally; install it only in Linux platforms

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMQKJONQX2KH3YEALAWQTTNE23TANCNFSM44VTMB2Q .

haz commented 3 years ago

It fail some checks?

https://travis-ci.com/github/aig-upf/tarski/jobs/504635208

gfrances commented 3 years ago

Yes, but they seem related to some code in a previous commit by @miquelramirez (easy to see the first failing commit here). @miquelramirez , do you think this is fixable? Or maybe I could move the NDL-related commits to a diff branch (they seem pretty self-contained, but I've only given a quick glance)?

miquelramirez commented 3 years ago

Cheers for the heads up, it's a trivial issue, will fix soon.

On Wed, 12 May 2021, 16:25 Guillem Francès, @.***> wrote:

Yes, but they seem related to some code in a previous commit by @miquelramirez https://github.com/miquelramirez (easy to see the first failing commit here https://github.com/aig-upf/tarski/commits/devel). @miquelramirez https://github.com/miquelramirez , do you think this is fixable? Or maybe I could move the NDL-related commits to a diff branch (they seem pretty self-contained, but I've only given a quick glance)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/103#issuecomment-839494623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMQKOISWZWLR2T2YSLSOLTNINNJANCNFSM44VTMB2Q .

miquelramirez commented 3 years ago

Should be fixed with commit b4be590ba4dfa5b05d8b11b5a2685fbeef4c5383