search

aig-upf / tarski

Tarski - An AI Planning Modeling Framework
Apache License 2.0
61 stars 20 forks source link

Preparing 0.2.0 Release: Merging ```hybrid``` into ```dev-0.2.0``` #41

Closed miquelramirez closed 5 years ago

miquelramirez commented 5 years ago

@emilkeyder - we're preparing the 0.2.0 release. If you have anything you would want to add to 0.2.0, please make a PR into dev-0.2.0 when hybrid is merged.

emilkeyder commented 5 years ago

Thanks for letting me know - I have some local changes but nothing ready to commit. Any idea when you'll do the final cut for 0.2.0 ?

On Thu, Jan 10, 2019 at 12:17 AM Miquel Ramírez notifications@github.com wrote:

@emilkeyder https://github.com/emilkeyder - we're preparing the 0.2.0 release. If you have anything you would want to add to 0.2.0, please make a PR into dev-0.2.0 when hybrid is merged.

You can view, comment on, or merge this pull request online at:

https://github.com/aig-upf/tarski/pull/41 Commit Summary

  • Parser files are back
  • Setup reqs updated
  • RDDL Parsing and Figuring out the mapping
  • Notebook Updated
  • Normalization experiments
  • ??
  • Updated parser files
  • Ensuring correct handling of end of line chars
  • Notebook updated
  • Notebooks and RDDL translator
  • Merge branch 'dev-0.2.0' into hybrid
  • Simple Evaluator
  • Built-in symbol implementation
  • Built-in definitions
  • Interpretation tests
  • RDDL I/O
  • RDDL I/O
  • Formula translation
  • If-Then-Else term
  • Notebook updated
  • Notebook update
  • New Theory
  • Work in progress
  • Evil Typo
  • RDDL Parser & Processing
  • Fixed typo
  • Notebook updated
  • RDDL translation
  • New Features and RDDL Parsing
  • RDDL parsing
  • RDDL Parsing
  • Aggregate Compound Terms
  • RDDL Writer
  • RDDL reading
  • RDDL Writing
  • RDDL Writing
  • Non-fluents writing
  • RDDL Writing
  • RDDL Writing
  • RDDL Writing
  • RDDL Writing
  • Aggregate Compound Terms
  • Double Integrator tutorial
  • Matrices & Vectors
  • Double Integrator Tutorial
  • Matrix Term interface
  • Matrix Arithmetic & Simplification
  • Interpretation of Matrix expressions
  • Issue #29: hash operator implemented
  • New Special function
  • Update .gitignore
  • Simplification
  • Merge branch 'hybrid' of https://github.com/aig-upf/tarski into hybrid
  • RDDL Parser
  • RDDL Support
  • Bug fix: initial state setup
  • partial fix to examples/blocksworld, still fails with bad arity message
  • examples/blocksworld.py
  • minimal test reproducing function arity issue
  • Merge pull request #31 from aig-upf/hybrid-emil-fixes
  • Update test_syntax.py
  • Revert "Emil's changes and fixes"
  • Merge pull request #32 from aig-upf/revert-31-hybrid-emil-fixes
  • Merge branch 'hybrid' into hybrid-emil-fixes
  • Merge branch 'hybrid-emil-fixes' into hybrid
  • Merge branch 'hybrid' of https://github.com/aig-upf/tarski into hybrid
  • Update fstrips.py
  • Update fstrips.py
  • Update fol.py
  • ite is now part of the Arithmetic theory
  • changes to write metric and a few other things
  • Merge pull request #38 from aig-upf/action-costs
  • Issue #39 Refactoring increase effects
  • Add derived predicates to tarski
  • Error handling for Derived predicate definitions
  • Merge pull request #40 from aig-upf/hybrid-add-derived

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/41, or mute the thread https://github.com/notifications/unsubscribe-auth/AfaV8tiEXUJK7HWrU5lpvae0NMKKcKqgks5vBszqgaJpZM4Z4zdO .

miquelramirez commented 5 years ago

Sometime next week, the earliest :)

Miquel

On Thu, 10 Jan. 2019, 17:44 emilkeyder <notifications@github.com wrote:

Thanks for letting me know - I have some local changes but nothing ready to commit. Any idea when you'll do the final cut for 0.2.0 ?

On Thu, Jan 10, 2019 at 12:17 AM Miquel Ramírez notifications@github.com wrote:

@emilkeyder https://github.com/emilkeyder - we're preparing the 0.2.0 release. If you have anything you would want to add to 0.2.0, please make a PR into dev-0.2.0 when hybrid is merged.

You can view, comment on, or merge this pull request online at:

https://github.com/aig-upf/tarski/pull/41 Commit Summary

  • Parser files are back
  • Setup reqs updated
  • RDDL Parsing and Figuring out the mapping
  • Notebook Updated
  • Normalization experiments
  • ??
  • Updated parser files
  • Ensuring correct handling of end of line chars
  • Notebook updated
  • Notebooks and RDDL translator
  • Merge branch 'dev-0.2.0' into hybrid
  • Simple Evaluator
  • Built-in symbol implementation
  • Built-in definitions
  • Interpretation tests
  • RDDL I/O
  • RDDL I/O
  • Formula translation
  • If-Then-Else term
  • Notebook updated
  • Notebook update
  • New Theory
  • Work in progress
  • Evil Typo
  • RDDL Parser & Processing
  • Fixed typo
  • Notebook updated
  • RDDL translation
  • New Features and RDDL Parsing
  • RDDL parsing
  • RDDL Parsing
  • Aggregate Compound Terms
  • RDDL Writer
  • RDDL reading
  • RDDL Writing
  • RDDL Writing
  • Non-fluents writing
  • RDDL Writing
  • RDDL Writing
  • RDDL Writing
  • RDDL Writing
  • Aggregate Compound Terms
  • Double Integrator tutorial
  • Matrices & Vectors
  • Double Integrator Tutorial
  • Matrix Term interface
  • Matrix Arithmetic & Simplification
  • Interpretation of Matrix expressions
  • Issue #29: hash operator implemented
  • New Special function
  • Update .gitignore
  • Simplification
  • Merge branch 'hybrid' of https://github.com/aig-upf/tarski into hybrid
  • RDDL Parser
  • RDDL Support
  • Bug fix: initial state setup
  • partial fix to examples/blocksworld, still fails with bad arity message
  • examples/blocksworld.py
  • minimal test reproducing function arity issue
  • Merge pull request #31 from aig-upf/hybrid-emil-fixes
  • Update test_syntax.py
  • Revert "Emil's changes and fixes"
  • Merge pull request #32 from aig-upf/revert-31-hybrid-emil-fixes
  • Merge branch 'hybrid' into hybrid-emil-fixes
  • Merge branch 'hybrid-emil-fixes' into hybrid
  • Merge branch 'hybrid' of https://github.com/aig-upf/tarski into hybrid
  • Update fstrips.py
  • Update fstrips.py
  • Update fol.py
  • ite is now part of the Arithmetic theory
  • changes to write metric and a few other things
  • Merge pull request #38 from aig-upf/action-costs
  • Issue #39 Refactoring increase effects
  • Add derived predicates to tarski
  • Error handling for Derived predicate definitions
  • Merge pull request #40 from aig-upf/hybrid-add-derived

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/41, or mute the thread < https://github.com/notifications/unsubscribe-auth/AfaV8tiEXUJK7HWrU5lpvae0NMKKcKqgks5vBszqgaJpZM4Z4zdO

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/aig-upf/tarski/pull/41#issuecomment-452982671, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbIKVTKsiHbLBdxnr_o3yFwVbY91eqlks5vBtnYgaJpZM4Z4zdO .

gfrances commented 5 years ago

Miquel has a very admissible deadline estimation function :-)

miquelramirez commented 5 years ago

All issues raised have been addressed

miquelramirez commented 5 years ago

@gfrances commit 97882f71648b6ce6ff74c4a7f1d0cbec844d642b should have solved the issues that were breaking our tests with the pyrddl parser. I have added a work around the problem. Going back over my past correspondence with pyrddl author I submitted a while ago a PR correcting some issues I had found with the parser (like not supporting empty declarations). Obviously, that hasn't been actioned yet.

There's a number of problems reported by tox, I am looking through them now.

miquelramirez commented 5 years ago

Okay @gfrances everything looks good now. Let me know if you have any other comments, otherwise I will proceed with the merge.

gfrances commented 5 years ago

Sorry I was travelling. I can have a look at this tonight, if you can wait, otherwise feel free to go ahead, no problem!

gfrances commented 5 years ago

Hi @miquelramirez ! Really happy that we're passing the tests again! I have still some concerns with the design, etc., but I think this should not prevent the merge to the dev-0.2 branch, we can keep discussing those on separate issues, if necessary.

One relevant point though: Should I merge to 0.2 my branch with DL stuff and keep developing on there the news stuff that I would like to implement (some, not all, of the things mentioned on the issues I opened last week)? Or would you rather have separate development branches? What's your own development plan?

miquelramirez commented 5 years ago

Hi @gfrances,

I just merged into dev-0.2.0 - didn't manage to read your message last night. Please, merge into dev-0.2.0 as it is meant to be the "sandbox"/"staging area" for master. I can see via Travis the state of the branch, and decide in an informed way when it is safe to sync my projects to it.

Once that is done, I have no inconvenient with the new features being developed directly there, or developed in specific branches. Probably the later makes more sense, if the development of those features hits a snag and gets delayed, won't be holding up updating master.

miquelramirez commented 5 years ago

That means that I want to retain hybrid until you have finished your merge, too.