aig-upf / tarski

Tarski - An AI Planning Modeling Framework
Apache License 2.0
61 stars 20 forks source link

Universal and conditional effects #49

Closed emilkeyder closed 5 years ago

emilkeyder commented 5 years ago

Add universal and conditional effects.

miquelramirez commented 5 years ago

Cheers @emilkeyder, I will get back to you in a couple days

emilkeyder commented 5 years ago

I'm confused by the errors - when I run locally the test passes, and what it's complaining about is something I had to fix previously (extra whitespace in the assertion of what the printed effect looks like). Anyway let me know if I'm missing something obvious or there are some changes I should make to fix it.

miquelramirez commented 5 years ago

Hi @emilkeyder,

looked at this a little bit today before getting pulled into other stuff and I am also a bit surprised by the tests failing. I will look into it for real tonight, when the girls are all asleep,

Miquel

miquelramirez commented 5 years ago

Okay, not sure what was the issue - perhaps your git client is very aggressive handling changes in whitespace of files?