search

aigilea / hp_spectre_x360_14_eu0xxx

Linux on HP Spectre X360 14-eu0000
GNU General Public License v2.0
45 stars 2 forks source link

Fingerprint works after modifying libfprint #17

Open alaincou opened 2 weeks ago

alaincou commented 2 weeks ago

I am using KDE on Debian Unstable.

Download last library https://gitlab.freedesktop.org/libfprint/libfprint

Add in the c file ./libfprint/drivers/synaptics/synaptics.c line " { .vid = SYNAPTICS_VENDOR_ID, .pid = 0x016C, }," Compiled libfprint and replaced /lib/x86_64-linux-gnu/libfprint-2.so.2.0.0

frprintd works! enroll, verify, pam...

christian-bendiksen commented 1 week ago

Great! Have you sent a patch upstream?

alaincou commented 1 week ago

Great! Have you sent a patch upstream? [No, I just wrote that in (https://gitlab.freedesktop.org/libfprint/libfprint)]

n3thshan commented 1 week ago

Please create a merge request. If it is accepted, users wont have to manually do all of this to get the sensor working. This will also benefit users like me who are using immutable distros who cant do this and test

n3thshan commented 1 week ago

i tried creating a merge request and even after requesting permission and getting approval from the freedesktop gitlab, i still dont see the create merge request button. Can anyone help me figure it out?

mariusagur commented 1 week ago

I am using KDE on Debian Unstable.

Download last library https://gitlab.freedesktop.org/libfprint/libfprint

Add in the c file ./libfprint/drivers/synaptics/synaptics.c line " { .vid = SYNAPTICS_VENDOR_ID, .pid = 0x016C, }," Compiled libfprint and replaced /lib/x86_64-linux-gnu/libfprint-2.so.2.0.0

frprintd works! enroll, verify, pam...

How did you build it? I keep getting errors about udev missing, even with udev, libudev-dev and python3-pyudev installed (debian testing)

Edit: Resolved it by running the following command: sudo apt-get build-dep libfprint

Dadoum commented 6 days ago

I submitted a merge request, it got approved and should be merged soon.

n3thshan commented 5 days ago

I submitted a merge request, it got approved and should be merged soon.

thank you so much for ur contribution! i see it has received approval as of now. is there anything else left for it to be merged?

n3thshan commented 21 hours ago

@Dadoum hi! whats the update on the merge request? does it need another person's approval to be merged or is it just refusing because of the pipeline error?

Dadoum commented 21 hours ago

@Dadoum hi! whats the update on the merge request? does it need another person's approval to be merged or is it just refusing because of the pipeline error?

I think it's due to the pipeline error, but I don't know why it doesn't work. It works on my computer.™

n3thshan commented 17 hours ago

its not ur fault. As Benjamin said, it will fix itself eventually and then will be merged as soon as the pipeline succeeds since we now have the approval as well! Im not too sure on how MRs work but if u can run the pipeline manually then and there, maybe miraculously it may work lol