search

aiida-vasp / parsevasp

A general parser for VASP
MIT License
13 stars 13 forks source link

Fixed class definitions #100

Closed espenfl closed 2 years ago

espenfl commented 2 years ago

Here we remove a few redundant object references and fix the __str__ definition.

codecov[bot] commented 2 years ago

Codecov Report

Merging #100 (949d8f3) into develop (4524d6a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #100   +/-   ##
========================================
  Coverage    80.39%   80.39%           
========================================
  Files           13       13           
  Lines         3396     3396           
========================================
  Hits          2730     2730           
  Misses         666      666
Impacted Files Coverage Δ
parsevasp/base.py 78.38% <100.00%> (ø)
parsevasp/incar.py 77.94% <100.00%> (ø)
parsevasp/kpoints.py 70.42% <100.00%> (ø)
parsevasp/poscar.py 68.47% <100.00%> (ø)
parsevasp/stream.py 91.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4524d6a...949d8f3. Read the comment docs.

atztogo commented 2 years ago

@espenfl, I think () is redundant in class BaseParser().

espenfl commented 2 years ago

@espenfl, I think () is redundant in class BaseParser().

Absolutely, thanks for spotting this @atztogo :)