search

aiida-vasp / parsevasp

A general parser for VASP
MIT License
13 stars 13 forks source link

Removed entry for now removed logger in docstring #102

Closed espenfl closed 2 years ago

espenfl commented 2 years ago

Small fix to now redundant section under parameter for logger.

codecov[bot] commented 2 years ago

Codecov Report

Merging #102 (828090e) into develop (573842a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #102   +/-   ##
========================================
  Coverage    80.31%   80.31%           
========================================
  Files           13       13           
  Lines         3381     3381           
========================================
  Hits          2715     2715           
  Misses         666      666
Impacted Files Coverage Δ
parsevasp/poscar.py 68.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 573842a...828090e. Read the comment docs.

atztogo commented 2 years ago

I found similar lines when I worked on #101, i.e., unused parameters in methods, where I wrote like "Not implemented" in their docstrings. I saw lines where variables are set but unused in codes, too. When I feel the variable name may indicate something, I commented out the line, otherwise, removed or replaced it by _.