search

aiida-vasp / parsevasp

A general parser for VASP
MIT License
13 stars 13 forks source link

Tentative fix to run pre-commit via tox on python 3.10 venv #124

Closed atztogo closed 1 year ago

atztogo commented 1 year ago

This is a tentative fix to run pre-commit via tox on python 3.10 venv on python 3.11 host. I need this PR to be merged because #123, however we should have many options about how to solve this issue, so I consider that this PR is a tentative fix.

After this PR, to run only pre-commit,

tox -e py310-pre-commit

rather than

tox -e pre-commit
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (13d56a9) 80.60% compared to head (de72cd9) 80.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #124 +/- ## ======================================== Coverage 80.60% 80.60% ======================================== Files 13 13 Lines 3478 3478 ======================================== Hits 2803 2803 Misses 675 675 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

atztogo commented 1 year ago

I close this PR, because this should be simpler.