aiida-vasp / parsevasp

A general parser for VASP
MIT License
13 stars 13 forks source link

Migration to ruff, and some updates #148

Closed atztogo closed 3 months ago

atztogo commented 3 months ago
atztogo commented 3 months ago

I found several tests had been overrode by other tests that have the respective same function names.

I found

atztogo commented 3 months ago

@zhubonan, I would like to ask you to review this PR.

I migrated to ruff. The ruff settings follow those of aiida-vasp. I added N803 for tests and N802 with respect to those of aiida-vasp.

I removed the tox setting. Then I updated .github/workflows/ci.yml. Now the tests run for python 3.9 to 3.12 independently without using tox. Pre-commit run in ci.yml was also removed. I hope pre-commit.ci is enough.

I found some issues on tests, which are written in my comment above. I hope those are not serious.

Ruff gave me warnings and I fixed them since those look like bugs. But I am not sure if I should fix them or not.