aiida-vasp / parsevasp

A general parser for VASP
MIT License
13 stars 13 forks source link

More stream items for checking #53

Closed zhubonan closed 3 years ago

zhubonan commented 3 years ago

Added more stream items for checking. Note that IBZKPT is a special case as multiple errors can have this, some of them are actually warnings are not fatal. Hence, I set it to recovery: true.

As discussed the suggests are removed unless we are sure it is the right one.

espenfl commented 3 years ago

@zhubonan I took the liberty to force push to a clean rebase from develop and update the suggestions. Thanks a lot for the contribution. I will now merge it.

zhubonan commented 3 years ago

Cool thanks. Sorry it slipped from my list earlier on!

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (bb2f683) into develop (56975fb) will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #53      +/-   ##
===========================================
+ Coverage    78.10%   78.14%   +0.04%     
===========================================
  Files            9        9              
  Lines         3009     3009              
===========================================
+ Hits          2350     2351       +1     
+ Misses         659      658       -1     
Impacted Files Coverage Δ
parsevasp/stream.py 92.36% <0.00%> (+0.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56975fb...bb2f683. Read the comment docs.

espenfl commented 3 years ago

@zhubonan No problem. Although, the strategy here does not sit right with me as by force pushing I formally take over the contribution. I have now fixed the tests etc. and if you want, please reset soft and do a new commit and force it yourself. That would be more ideal as this is your contribution. However, if you are okey with this, I will proceed with the merge.

zhubonan commented 3 years ago

@espenfl no worries, just proceed with the merge! Thanks for the final touches!