IncarItem doesn't have ERROR_MESSAGES but used in

aiida-vasp / parsevasp

A general parser for VASP

MIT License

13 stars 13 forks source link

IncarItem doesn't have ERROR_MESSAGES but used in #68

Closed atztogo closed 3 years ago

atztogo commented 3 years ago

At current develop branch (cd1cd18dea).

IncarItem doesn't have self.ERROR_MESSAGES and similar objects but they are used in it. Is it expected to be passed from Incar class?

espenfl commented 3 years ago

@atztogo Thanks. Yes I also noticed this yesterday when I got some errors in that class. I will fix it today (in develop). Do you need a release?

And with respect to how to do it, no I do not think we should inherit or pass stuff from the class. The IncarItem is a separate class. I will instead raise exceptions for those. It is not connected to the base parser class either. Objections?

atztogo commented 3 years ago

No release needed. Update of develop is fine. I have no objection. Thanks!

espenfl commented 3 years ago

Closed by #69. Thanks for raising. See also #70.