search

aiidalab / aiidalab-docker-stack

Docker images with the basic software stack for AiiDAlab
https://aiidalab.net
Other
9 stars 14 forks source link

Pin jupyter-notebook version #469

Closed danielhollas closed 5 months ago

danielhollas commented 5 months ago

In https://github.com/aiidalab/aiidalab-qe/issues/640, @superstar54 and I were debugging an issue with a stalled pip installation, likely caused by his quite complex dev environment. One thing I noticed that while the pip was trying hard to solve the dependencies, it started backtracking and looking at older versions of some of the core Jupyter libraries, most notably Jupyter notebook (notebook package). This is definitely not desirable, and if pip was able to finish, it would likely break the container.

We've been having discussions in the past about pinning some jupyter-related packages to prevent this scenario from happening. I'll open a separate issue for that, but for starters I think we should pin at least the notebook package. We definitely don't want users to be able to downgrade the version, and we also don't want them to upgrade it, since we know that v7 will currently not work as it is a completely different architecture.

danielhollas commented 5 months ago

@unkcpz would you have time to take a look in the next few days? I'd like to publish a new version of the image after we merge this.

unkcpz commented 5 months ago

Yes, it is in my list, I'll have a look asap. Sorry.

danielhollas commented 5 months ago

No worries at all, thanks!

danielhollas commented 5 months ago

Thanks @unkcpz. I've added some tests. After merging this I'm going to publish a new version.