search

aiidalab / aiidalab-docker-stack

Docker images with the basic software stack for AiiDAlab
https://aiidalab.net
Other
9 stars 14 forks source link

Updating the *before_notebook* `20_start-postgresql.sh` and `40_prepare_aiida.sh` #476

Closed mikibonacci closed 4 months ago

mikibonacci commented 4 months ago

Fixings are done as for arm64 I encountered issues in restarting the container.

1 - Deleting old ${PSQL_LOGFILE}.1.gz file before trying to compressed again in 20_start-postgresql.sh. Otherwise, this can give errors and so the container will exit with non-zero status. 2 - Clean stop of the daemon before the "verdi storage migrate --force" in 40_prepare_aiida.sh. This is done because sometimes the restart of the docker container will give error in trying to migrate, as the daemon is still running. I am not able to reproduce the error in a standard way, however.

danielhollas commented 4 months ago

Thanks for catching these issues.

I encountered issues in restarting the container.

How exactly are you restarting the container?

mikibonacci commented 4 months ago

For the restart, I used aiidalab-launch and also the manual startup (docker desktop and terminal). These issues are there only when I use arm64 machine (my Mac). That's strange.

danielhollas commented 4 months ago

@mikibonacci can you test the latest version of the image (ghcr.io/aiidalab/full-stack:pr-476).

Once you confirm that it works reliably for you I'll merge and release a new version.

Thanks for catching this and the fixes!

mikibonacci commented 4 months ago

Hi @danielhollas , I tested the ghcr.io/aiidalab/full-stack:pr-476 and it works well for me! Thanks a lot for the review!

danielhollas commented 4 months ago

Thanks for testing @mikibonacci. I'll release a new version soon with your fix.

I've opened #477 as a follow up to this to prevent these issues in the future.

danielhollas commented 4 months ago

@mikibonacci new version is released. :rocket: