aiidalab / aiidalab-home

AiiDAlab Home App
MIT License
5 stars 9 forks source link

Make the separator between apps in Appstore visible #142

Open danielhollas opened 1 year ago

danielhollas commented 1 year ago

In the appstore we render all apps below each other. There is <hr> element as a visual separator, but it is not that much visible, (on one of my monitors with lower brightness, it is actually invisible). https://github.com/aiidalab/aiidalab-home/blob/0b1c618d72bf170b2a51192adcc6ca1727c2af02/home/app_store.py#L170, but (at least in my browser) it is not visible since its color is white.

We need to add some styling to it. We should also adjust the overall whitespace around the apps, it seems currently there's a bit too much of it.

danielhollas commented 1 year ago

Styling an <hr> tag seems to be bit of a pain, see

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hr https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_hr_align_css https://stackoverflow.com/questions/4151743/how-can-i-change-the-thickness-of-my-hr-tag https://www.thoughtco.com/styling-horizontal-rule-tag-3466399

It would be nicer instead of inserting a separate <hr> in between tags to utilize the ::before CSS pseudoclass. Alternatively, we could use a top border around the app.

danielhollas commented 1 year ago

As part of this, we could also take a look at removing supposedly superfluouos HBoxes, see https://github.com/aiidalab/aiidalab-home/pull/130#discussion_r1114723520