search

aiidalab / aiidalab-home

AiiDAlab Home App
MIT License
5 stars 9 forks source link

Add detached check before raise imcompatible warning. #148

Closed unkcpz closed 1 year ago

unkcpz commented 1 year ago

fixes #https://github.com/aiidalab/aiidalab/issues/373

The detached check works fine but since it is detached the version will be UNKNOWN and in the compatible check it is regarded as incompatible. I also add a docstring in https://github.com/aiidalab/aiidalab/pull/374

danielhollas commented 1 year ago

@unkcpz I do not think this is the correct approach to fix this. In this way, detached applications would always be compatible, but that's not true in general.

We should instead modify the is_incompatible function to work properly. Specifically, when the app is detached, we should pull the dependencies from the setup.cfg and check them. We are already doing that somehow when the app is not registered so it should not be a completely new code. Can you take a look at how this all works for unregistered apps? That should give you a hint how to proceed,

unkcpz commented 1 year ago

Ah, I think you are correct, AGAIN :shrug:

The compatibility check is only done for app not registred, we need to extend it to also installed and detached. I'll update the PR later.

unkcpz commented 1 year ago

Hi @danielhollas, I did the change in https://github.com/aiidalab/aiidalab/pull/374 and this one is not needed anymore.