search

aiidalab / aiidalab-home

AiiDAlab Home App
MIT License
5 stars 9 forks source link

Implement tests #42

Closed csadorf closed 4 years ago

csadorf commented 4 years ago

I've discovered an issue with these tests, specifically the test are executed for apps/home, but the version to be tested is mounted as apps/app.

csadorf commented 4 years ago

Thanks, @csadorf, looks awesome.

Thank's. 😃

q: can we also test the terminal?

Yes, I'll add a test for that.

csadorf commented 4 years ago

@dou-du Would you be able to make those last requested changes?

dou-du commented 4 years ago

@dou-du Would you be able to make those last requested changes?

Sorry, I am not very clear. Do you want me to implement the sleepy delay and the test for the terminal ? By the way, I do not have permission to edit for this repository.

csadorf commented 4 years ago

@dou-du Would you be able to make those last requested changes?

Sorry, I am not very clear. Do you want me to implement the sleepy delay and the test for the terminal ? By the way, I do not have permission to edit for this repository.

Yes, exactly. That would be a good chance to get familiar with how to implement these tests. We can give you access, but since this PR is from my fork, you would want to fork this repository and then create the PR into my branch anyways.

dou-du commented 4 years ago

@dou-du Would you be able to make those last requested changes?

Sorry, I am not very clear. Do you want me to implement the sleepy delay and the test for the terminal ? By the way, I do not have permission to edit for this repository.

Yes, exactly. That would be a good chance to get familiar with how to implement these tests. We can give you access, but since this PR is from my fork, you would want to fork this repository and then create the PR into my branch anyways.

Sure, I will do it. Thanks.