search

aiidalab / aiidalab-launch

Tool to launch AiiDAlab on a local workstation.
MIT License
5 stars 3 forks source link

Deprecate py3.8 and deal with action warnings #183

Closed unkcpz closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.22 :tada:

Comparison is base (d3c121f) 86.54% compared to head (466cba0) 86.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #183 +/- ## ========================================== + Coverage 86.54% 86.76% +0.22% ========================================== Files 9 9 Lines 907 907 ========================================== + Hits 785 787 +2 + Misses 122 120 -2 ``` | Flag | Coverage Δ | | |---|---|---| | py-3.10 | `86.65% <ø> (+0.22%)` | :arrow_up: | | py-3.11 | `86.43% <ø> (ø)` | | | py-3.8 | `?` | | | py-3.9 | `86.50% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab#carryforward-flags-in-the-pull-request-comment) to find out more. [see 1 file with indirect coverage changes](https://app.codecov.io/gh/aiidalab/aiidalab-launch/pull/183/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidalab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielhollas commented 1 year ago

Why deprecate 3.8? That is still a version in use by older Linux distros I think, let's not make things more complicated for potential users.

unkcpz commented 1 year ago

Okay, that is true, I was at this repo on other changes and find this from README https://github.com/aiidalab/aiidalab-launch#compatibility.

danielhollas commented 1 year ago

Interesting. TBH I don't really see a reason why this package should follow NEP 29. This package does not depend on the Python scientific ecosystem (numpy et al). On the contrary, since it is a CLI tool, it's likely to be installed system-wide using Linux distribution Python, that is often lagging behind. So I would simply vote for not following NEP 29.

unkcpz commented 1 year ago

Yes, agree. I close this PR.