Open unkcpz opened 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
33c7a26
) 86.32% compared to head (afb325b
) 86.38%.:exclamation: Current head afb325b differs from pull request most recent head 79eb2db. Consider uploading reports for the commit 79eb2db to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @danielhollas The test is added.
I believe this code should be called at the very end right?
I was thinking about this as well, but still have not convinced myself although it makes more sense in logic. Because once the profile is removed there is no way to remove volume through the command line again. However, if the profile deletes is failed after cleaning the volume, the profile still can be deleted.
Also please add a specific WARNING and confirmation for this case.
This is taken care of by reset
already, it asks the user to input the profile name to confirm.
Anyway, I moved the purge to the end after the profile was removed, if you think it is better to move it before, I'll change it.
Hi @danielhollas, I think this one is ready to have a second review.
fixes #172
The
aiidalab-launch reset
can be used to purge the data mounted such as the home mount as a docker volume and conda volume mounted. Usually, when deleting the profile, users are supposed to reset the data as well, in this PR, I call reset before the profile remove.