Closed danielhollas closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3d7c9d2
) 85.86% compared to head (23197e3
) 86.07%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Huh, interestingly, when I added back the check-manifest
file, it started failing in pre-commit bot with
['/pc/clone/LLopfktuRsCG39y1Br0Ylw/py_env-python3/bin/python', '-m', 'build', '--sdist', '.', '--outdir', '/tmp/check-manifest-64gqzu8s-sdist'] failed (status 1):
* Creating venv isolated environment...
ERROR Failed to create venv. Maybe try installing virtualenv.
Command '/tmp/build-env-iai5zihp/bin/python3.11 -m ensurepip --upgrade --default-pip' failed with return code 1
stdout:
/tmp/build-env-iai5zihp/bin/python3.11: No module named ensurepip
It doesn't seem like an actual issue, just some missing dependencies. For now I've removed the build-related setup from pyproject.toml
which seems to solve this. Let's deal with it in a follow-up PR.
aiida-core recently switched to ruff, and I've been using it for my app for some time. IMO we should consider slowly switching AiiDAlab repos as well. @unkcpz @yakutovicha LMK what you think.
I've enabled a couple more rules than there were before, based on my judgment and previous experience. More might be useful, but this is a reasonable start IMO.
I've also removed a couple of hooks that did not seem as useful, now that the codebase and its configuration is quite stable. But I am happy to revert.