aiidalab / aiidalab-on-azure

A Terraform template to deploy AiiDAlab via Azure Kubernetes Services (AKS)
MIT License
3 stars 0 forks source link

fix pre-commit on ci #32

Closed ltalirz closed 1 year ago

ltalirz commented 1 year ago

The terraform-fmt check requires terraform to be installed and therefore was failing on pre-commit.ci. While hooks in the .pre-commit-config.yaml can install extra dependencies per hook via the additional_dependencies key [1] I don't believe terraform can be installed this way currently, and pre-commit.ci does not seem to provide additional mechanisms for installing dependencies.

We therefore disable those checks on pre-commit.ci and switch to running pre-commit on GitHub actions, where we have more control over the environment.

Note: Since we are running pre-commit on GitHub actions, one might want to disable pre-commit.ci for this repository altogether, but it is currently enabled across all repositories of the aiidalab organization. Disabling it would require enabling pre-commit.ci for each repository individually.

[1] https://pre-commit.com/#config-additional_dependencies